GitHub Issue 1073: Updating a List MVTC field shows array in audit for values with quotes#2954
Merged
GitHub Issue 1073: Updating a List MVTC field shows array in audit for values with quotes#2954
Conversation
…r values with quotes
labkey-susanh
approved these changes
Apr 17, 2026
| checker().verifyEquals("Update: old audit value not as expected", | ||
| _auditLogHelper.joinMultiChoiceForAudit(plainValue), updateOldAuditValue); | ||
| checker().verifyEquals("Update: new audit value not as expected", | ||
| _auditLogHelper.joinMultiChoiceForAudit(quotedValue2), updateNewAuditValue); |
Contributor
There was a problem hiding this comment.
Is it worth adding a check for removing a value since that's where there is potential for behavioral change?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Related Pull Requests
Changes